CBG-3913 replace parseStreamWithXattr with sg-bucket function #6812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I was thinking about changing |
adamcfraser
previously approved these changes
May 9, 2024
adamcfraser
requested changes
May 10, 2024
| return nil, nil | ||
| } | ||
| return nil, err | ||
| return nil, fmt.Errorf("Could not parse DCP attachment sync data: %w", err) |
There was a problem hiding this comment.
This looks like a functional change if the xattr isn't found. Should it be checking if value was found?
There was a problem hiding this comment.
This looks like a functional change but parseXattrStreamData never returned ErrXattrNotFound. That said, I should catch ErrXattrInvalidLen though realistically this is also an error condition where we probably could consider stopping.
adamcfraser
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on couchbase/sg-bucket#122 and couchbase/sg-bucket#123
DecodeValueWithXattrs.Pre-review checklist
fmt.Print,log.Print, ...)base.UD(docID),base.MD(dbName))docs/apiDependencies (if applicable)
Integration Tests
GSI=true,xattrs=truehttps://jenkins.sgwdev.com/job/SyncGateway-Integration/2406/